search

docker-flow / docker-flow-proxy

Docker Flow Proxy
https://docker-flow.github.io/docker-flow-proxy/
MIT License
317 stars 189 forks source link

Redirect unless https proto #68

Closed audunhalland closed 5 years ago

audunhalland commented 5 years ago

Implements the required change in order to fix #67 .

A new service query parameter redirectUnlessHttpsProto is added, enabling a previously (short-term) supported feature, that was since removed.

audunhalland commented 5 years ago

Build failure, error message appears to be unrelated to my changes.

thomasjpfan commented 5 years ago

Can you force the CI to run again with:

git commit --allow-empty -m "Trigger CI"
audunhalland commented 5 years ago

@thomasjpfan build error looks related to https://github.com/sirupsen/logrus/issues/824. Looks like some windows port thingy that I'm not familiar with and also I'm not a golang expert at all so I'm not sure how to fix it.

dgsb commented 5 years ago

@audunhalland this is indeed a new dependency which has been added in order to perform colored output on windows. To fix your build for windows target a simple go get should be enough to fix your build.

audunhalland commented 5 years ago

After a bit of searching in the dark it seems to fail inside the cross-compile container vfarcic/gox. The entrypoint of that image is

#!/usr/bin/env bash

go get -d -v -t

gox --output="$1_{{.OS}}_{{.Arch}}" -osarch="linux/amd64 linux/arm windows/amd64 darwin/amd64"

Is there some conditional arch-based library selection going on so that it calling go get "outside" gox ... won't work?

thomasjpfan commented 5 years ago

@audunhalland Thanks for looking into it. It seems go get seems to avoid getting windows dependencies when ran in a non-windows environment.

I have been considering moving this project to go modules to avoid build issue such as this. Fixing the build process is out of scope for this PR. I will fix the build process in another PR, so that this PR can proceed.

thomasjpfan commented 5 years ago

@audunhalland Can you merge the master branch with this PR? This should fix the build issues.