docker-flow / docker-flow-proxy

Docker Flow Proxy
https://docker-flow.github.io/docker-flow-proxy/
MIT License
317 stars 189 forks source link

Feature: Add multiple configuration lines with 'BackendExtra' #85

Closed aisbergg closed 2 years ago

aisbergg commented 5 years ago

It would be nice to add multiple lines to the backend with BackendExtra. Like other parameters the string should be separated with a comma.

thomasjpfan commented 5 years ago

Currently, BackendExtra does not support the comma to new-line notation. This may be because there are some haproxy options that use comma, such as resolve-opts: https://cbonte.github.io/haproxy-dconv/1.8/configuration.html#5.2-resolve-opts

dimovnike commented 5 years ago

This would be definitely great to have. I also need this option.

chrsch commented 5 years ago

I also would love to see this.

thomasjpfan commented 5 years ago

My only concern with adding this feature using comma as a separator is that it will break backwards compatibility. For example:

http-request set-header x-path %[hdr(x-path),regsub(/+,/,g)]

In this case, the comma needs to be there.

chrsch commented 5 years ago

I see. Two quick options then came to my mind earlier this day:

thomasjpfan commented 5 years ago

We could give the user complete control by adding BackendExtraMultilineSeparator.

chrsch commented 5 years ago

Oh yes I like this idea.

vfarcic commented 5 years ago

This project needs adoption. I moved to Kubernetes and cannot dedicate time to this project anymore. Similarly, involvement from other contributors dropped as well. Please consider contributing yourself if you think this project is useful.

lle0x commented 2 years ago

Dear @aisbergg

If this issue is still relevant, please feel free to leave a comment here.

aisbergg commented 2 years ago

I moved to Traefik