search

docker-library / buildpack-deps

MIT License
445 stars 113 forks source link

Add "shared-mime-info" #120

Closed tianon closed 3 years ago

tianon commented 3 years ago

This is especially for freedesktop.org.xml, which is needed for a recent change to the mimemagic Ruby Gem (due to licensing incompatibility).

See https://github.com/docker-library/ruby/issues/344 for more details (https://github.com/mimemagicrb/mimemagic/issues/97 -> https://github.com/mimemagicrb/mimemagic/commit/cd65290a28e58974ff0c5fa1d3f2ce858035f177).

tianon commented 3 years ago

Given this is already part of Ruby's non-slim variants, I'm more on the fence here. However, looking at https://github.com/docker-library/buildpack-deps/runs/2157573634?check_suite_focus=true#step:8:19 vs https://github.com/docker-library/buildpack-deps/runs/2194879926?check_suite_focus=true#step:8:9, we must already have all the dependencies of this package, because there's literally no discernible difference in the final image size (803MB vs 803MB), so it's a pretty harmless add from what I can see.

tianon commented 3 years ago

Ahhh, the reason there's no size change is because this is already included. Should've started by checking that. :smile: