Add apt-get clean, ensure no-reccomended packages installed

docker-library / buildpack-deps

MIT License

450 stars 115 forks source link

Add apt-get clean, ensure no-reccomended packages installed #20

Closed sammcj closed 9 years ago

sammcj commented 9 years ago

further reduce image size

yosifkit commented 9 years ago

The --no-install-recommends probably needs more exploration:

what packages are no longer installed?
- are any of them needed or useful for this image?
what is the size savings?

This is partly related to #16, since that is also about reducing the size by limiting the packages installed and this change could affect the plans there.

The apt-get clean is not necessary, because it is already built in to apt-get update.

sammcj commented 9 years ago

You're totally right about apt-get clean @yosifkit - I didn't spot that in the upstream when I checked - that's really great.

--no-install-recommends can make a pretty large difference with Debian, for example if you install ruby-gems Debian will by default install build-essential which is not only large, but bakes in compilers to your Docker images.

tianon commented 9 years ago

He means specifically for this image; getting a list of exactly which packages are no longer included due to this change would be the first step in properly evaluating it.

Basically, we're looking for the result of diffing the output of "docker run --rm buildpack-deps dpkg --list-selections" from before and after this change.