search

docker-library / cassandra

Docker Official Image packaging for Cassandra
Apache License 2.0
262 stars 281 forks source link

Override cassandra.yaml config file through env variables #233

Closed sebdoido closed 2 years ago

sebdoido commented 3 years ago

Currently, we need to override some params from cassandra.yaml but it was not possible previously through the determinist list of items that could be overriden.

through this PR, we check the top-level keys of settings defined in cassandra.yaml file Meaning that it will be possible to override some of those top-level params withouth any other hack or Docker fork (as we were doing on our side in the past).

tianon commented 3 years ago

I think https://github.com/docker-library/cassandra/pull/122#issuecomment-426774071 is pretty relevant here.

sebdoido commented 3 years ago

Thanks for your prompt reply. I had already read this comment (and the other PR where people were trying to extend the list of settings that could be overriden).

However, i was thinking this PR was a little bit different in the approach. I didn't extend a determinist list (how do we consider that one settings is more important to be overriden regarding another one?? but i was handling that in a generic way by listing all top-level key that are currently defined in the cassandra.yaml .. so.. that could be overriden maybe in a certain context.

Taymindis commented 2 years ago

is this supporting those variable not inside cassandra.yaml? for example enable_sasi..... , I have created with #243 which support existing and not exisitng