docker-library / openjdk

Docker Official Image packaging for EA builds of OpenJDK from Oracle
http://openjdk.java.net
MIT License
1.14k stars 471 forks source link

Dockerfile /openjdk/11/jdk/buster broken on gpg check #462

Closed paul-bormans closed 3 years ago

paul-bormans commented 3 years ago

When building the /openjdk/11/jdk/buster Dockerfile i ran into issue's with gpg:

Saving to: ‘openjdk.tgz.asc’

 0K                                    100% 16.9M=0s

2021-06-22 07:11:19 (16.9 MB/s) - ‘openjdk.tgz.asc’ saved [566/566]

Increased logging level:

HTTP request sent, awaiting response... 200 OK Length: 566 [application/octet-stream] Saving to: ‘openjdk.tgz.asc’

 0K                                    100% 8.58M=0s

2021-06-22 07:17:58 (8.58 MB/s) - ‘openjdk.tgz.asc’ saved [566/566]

wglambert commented 3 years ago

See https://github.com/docker-library/faq#openpgp--gnupg-keys-and-verification (especially https://github.com/tianon/pgp-happy-eyeballs)

https://github.com/docker-library/official-images/issues/4252#issuecomment-381783035

TLDR; GPG servers are extremely flaky . . .

However in this instance that pool.sks-keyservers.net is no longer existent https://sks-keyservers.net/overview-of-pools.php We don't run into this issue during builds because that address is just a stand-in that gets DNS hijacked to point at a running instance of https://github.com/tianon/pgp-happy-eyeballs which queries multiple keyservers at once to get the fastest successful result.

You could add more servers to try https://github.com/docker-library/php/issues/586#issue-296627087

yosifkit commented 3 years ago

Related comment:

See https://github.com/docker-library/faq#openpgp--gnupg-keys-and-verification (especially https://github.com/tianon/pgp-happy-eyeballs) for why I haven't actually been affected by this directly, but yes, this should definitely be updated to a different keyserver now that SKS is dead. -https://github.com/tianon/dockerfiles/issues/121#issuecomment-866235268

Fixed by https://github.com/docker-library/openjdk/commit/20e86dbd02a19bca2f66b46bc3e8b00170f6f69c