search

docker-library / openjdk

Docker Official Image packaging for EA builds of OpenJDK from Oracle
http://openjdk.java.net
MIT License
1.14k stars 471 forks source link

Adding Support for Windows Server Core 2022 #472

Closed AdrianDeWinter closed 2 years ago

AdrianDeWinter commented 2 years ago

Added Windows Server Core LTSC 2022 as a target plattform. I had need for a Server 2022 based openjdk image and built one locally, it seems to work without any issues so far. Is haven't tested every single image the change would spawn, but i assume the CI pipeline takes care of that?

tianon commented 2 years ago

Thanks! I've just pushed an update that includes all the generated files too (CI won't be able to test it properly otherwise) and fixed the ordering -- if it isn't in descending order, the generated manifest lists end up wrong and the shared tags will pull less efficient images sometimes. :sweat_smile:

tianon commented 2 years ago

Doh, those failing JRE tests are a specific flavor of a recurring issue with those tests we have (where we need a suitable JDK available to build some binary files for the JRE to try running and we're in a chicken-and-egg situation with this PR again :joy:).

tianon commented 2 years ago

Thanks again!

AdrianDeWinter commented 2 years ago

Hey, thanks for mergin this. Is there anwhere i can find out more obout what exactly is necessary for the CI to run properly? It says in the readme that information for contributin can be found on the dcker hub page, but there is not exactly much there aside from license information.

I am considering to add Server 2019 as well. There is that open PR for 1903, but i would add a couple more, mainly ltsc2019 instead of 1903 specifically, but also some of the Semi-Annual Channel versions (1909, 2004 and 20H2, currently). Do i just add the target versions to versions.json and versions.sh and run the latter?

tianon commented 2 years ago

Well, once this goes all the way through (https://github.com/docker-library/official-images/pull/11167) the JRE tests will work, it's just a rough edge case that might even only really apply to Windows anymore given Linux is more forgiving about running containers.

Regarding Server 2019, that's what 1809 is; see https://docs.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/base-image-lifecycle, especially:

Server Core Long-Term, Semi-Annual 2019, 1809