docker-library / owncloud

Docker Official Image packaging for ownCloud
101 stars 77 forks source link

Upgrade PHP to PHP 7 #41

Closed mouhamed closed 6 years ago

mouhamed commented 8 years ago

Hello guys,

Since PHP 7 is officially released and own cloud claims officially latest version (8.2) is compatible, why not upgrade the source docker image to PHP 7 ?

Thanks, Mouhamed

beingalink commented 8 years ago

I'd also like to see an owncloud:fpm image based on php 7. I think this would be perfect for testing compatibility before shipping it.

lazyfrosch commented 8 years ago

How about one of you guys testing the image with a FROM php:7 and give a PR?

tianon commented 8 years ago

Do plugins have broad support for it yet? I know over in Wordpress land, compatibility is still a little bit rocky.

LukasReschke commented 8 years ago

This will break stuff such as the calendar and contacts app. I'd advocate to wait until we release ownCloud 9 in March (or so) as this version has some more compatibility fixes. Base ownCloud installation should work fine though.

mouhamed commented 8 years ago

owncloud 9 is released now and is compatible with PHP 7.

sbani commented 8 years ago

I upgraded the image to php7-fpm but can't install memcache(d). Redis and apcu works fine.

Not using php7-fpm is another possibility. I could create an alpine version or another one based on package manager installations.

Please let me know if one of you is able to install/compile memcached for php7 based on the php7-fpm docker image.

beingalink commented 8 years ago

@sbani I'm using following install routine in my dockerfile for the PECL extensions:

# PECL extensions
RUN pecl install APCu
RUN git clone -b php7 https://github.com/phpredis/phpredis.git \
        && cd phpredis \
        && phpize && ./configure && make && make install && cd .. && rm -rf phpredis
RUN git clone -b php7 https://github.com/php-memcached-dev/php-memcached.git \
        && cd php-memcached \
        && phpize && ./configure && make && make install && cd .. && rm -rf php-memcached
RUN docker-php-ext-enable apcu redis memcached

This seems to work for me.

sbani commented 8 years ago

Thanks @beingalink. As you can see I'm doing nearly the same but without a git checkout (I download instead).

But works fine

tianon commented 6 years ago

Fixed via https://github.com/docker-library/owncloud/pull/89. :+1: