search

docker-library / php

Docker Official Image packaging for PHP
https://php.net
MIT License
3.79k stars 2k forks source link

Add PHP 8.3 RC #1414

Closed jnoordsij closed 1 year ago

jnoordsij commented 1 year ago

Note the second commit should be the result of the bot when the QA releases page is updated, but I manually added it to test image builds a little ahead.

Note: this means it probably is a good thing to wait for the release to appear there before merging.

yosifkit commented 1 year ago

Thanks for the PR!

Ah, the verify templating is failing because the execute permission was lost:

$ ./apply-templates.sh
...
$ git diff
diff --git a/8.3-rc/bullseye/apache/apache2-foreground b/8.3-rc/bullseye/apache/apache2-foreground
old mode 100644
new mode 100755
diff --git a/8.3-rc/buster/apache/apache2-foreground b/8.3-rc/buster/apache/apache2-foreground
old mode 100644
new mode 100755
jnoordsij commented 1 year ago

Thanks for the PR!

Ah, the verify templating is failing because the execute permission was lost:

$ ./apply-templates.sh
...
$ git diff
diff --git a/8.3-rc/bullseye/apache/apache2-foreground b/8.3-rc/bullseye/apache/apache2-foreground
old mode 100644
new mode 100755
diff --git a/8.3-rc/buster/apache/apache2-foreground b/8.3-rc/buster/apache/apache2-foreground
old mode 100644
new mode 100755

Ah thanks, figured it would be a permission issue since I usually run into those on my machine. Fixed those!

tianon commented 1 year ago

Note: this means it probably is a good thing to wait for the release to appear there before merging.

Makes sense; I guess we'll keep an eye on https://github.com/php/web-qa/commits/master :sweat_smile:

jnoordsij commented 1 year ago

Looks all set! Will be a race to the bot updating 8.2-rc in the master branch and causing a merge conflict? 😅