search

docker-library / php

Docker Official Image packaging for PHP
https://php.net
MIT License
3.81k stars 2k forks source link

Set the PHP_BUILD_PROVIDER variable #1441

Closed TimWolla closed 9 months ago

TimWolla commented 1 year ago

see https://github.com/php/php-src/blob/789867e844dc0465fe01a703a1bef2a7dba0c62b/configure.ac#L1500-L1502 see https://phpc.social/@remi/110543114152140626

TimWolla commented 1 year ago

Example screenshot (with messed up quoting, thus cutting off at the space, but I didn't want to rebuild, because it takes ages):

image

tianon commented 9 months ago

Oof, looking at that upstream block is giving me some hives -- we should probably set PHP_UNAME too (like the intent of https://salsa.debian.org/php-team/php/-/blob/0085363b2a1af13bcf20b34f22eb38a0263ecead/debian/patches/0024-php-5.4.9-fixheader.patch) :confused:

Maybe we set the provider to "https://github.com/docker-library/php" so it doesn't really matter as much where the builds happened? I guess that won't help for modified builds, but I don't think there's much we can actually do there (and it's then an accurate pointer to where the source originated, even if it was then modified).

Also, I'd prefer to set these in the RUN line as local environment variables (instead of ARG, which has other annoying behaviors).

TimWolla commented 9 months ago

Updated.