Do not delete source files when debugging

docker-library / php

Docker Official Image packaging for PHP

https://php.net

MIT License

3.77k stars 2k forks source link

Do not delete source files when debugging #1496

Open yyny opened 4 months ago

tianon commented 4 months ago

This "oh, but one more thing" is actually part of the reason why we resisted implementing DOCKER_PHP_ENABLE_DEBUG for so long :sweat_smile: :heart:

In this specific case, this is really trivial to implement via docker-php-source extract post-build, so without a stronger justification than "it'd be handy", I'm afraid this one is a likely decline. :bow:

mvorisek commented 4 months ago

I support this PR. When debug build is enabled, it does not make any sense to remove the sources. I understand the post from @tianon, but let's make developers live not harder.

yyny commented 4 months ago

docker-php-source extract wouldn't quite work for me because I am patching the sources.