search

docker-library / postgres

Docker Official Image packaging for Postgres
http://www.postgresql.org
MIT License
2.2k stars 1.14k forks source link

Add 17 beta1 #1244

Closed LaurentGoderre closed 5 months ago

LaurentGoderre commented 6 months ago

Fixes #1243

LaurentGoderre commented 6 months ago

Still need to fix the alpine build.

LaurentGoderre commented 6 months ago

For some reason the man pages aren't generated but the build doesn't fail and then fails trying to install them

tianon commented 5 months ago

https://salsa.debian.org/postgresql/postgresql/-/commit/58018cc8142a66da166ca56f4bde354c551d90a0 is really benign so there must be something we've missed in the interim :eyes:

tianon commented 5 months ago

Something in https://salsa.debian.org/postgresql/postgresql/-/compare/16...17 seems more likely :thinking:

LaurentGoderre commented 5 months ago

I found the source of the issue. It is the template override

https://github.com/postgres/postgres/blob/master/doc/src/sgml/stylesheet-man.xsl#L103-L113

Which always return 0 and therefore nothing is written as per

https://github.com/postgres/postgres/blob/master/doc/src/sgml/stylesheet-man.xsl#L128

LaurentGoderre commented 5 months ago

It could be related to needing to install docbook. The following patches makes it work

diff --git a/stylesheet-man.xsl b/stylesheet-man.xsl
index fcb485c..6ba9768 100644
--- a/stylesheet-man.xsl
+++ b/stylesheet-man.xsl
diff --git a/stylesheet-man.xsl b/stylesheet-man.xsl
index fcb485c..daac4fd 100644
--- a/stylesheet-man.xsl
+++ b/stylesheet-man.xsl
@@ -1,5 +1,6 @@
 <?xml version='1.0'?>
 <xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform"
+               xmlns:d="http://docbook.org/ns/docbook"
                 xmlns:exsl="http://exslt.org/common"
                 version='1.0'
                 exclude-result-prefixes="exsl">
@@ -103,8 +104,8 @@
 <!-- overridden from common/refentry.xsl -->
 <xsl:template name="get.refentry.section">
   <xsl:choose>
-    <xsl:when test="refmeta/manvolnum">
-      <xsl:value-of select="refmeta/manvolnum"/>
+    <xsl:when test="d:refmeta/d:manvolnum">
+      <xsl:value-of select="d:refmeta/d:manvolnum"/>
     </xsl:when>
     <xsl:otherwise>
       <xsl:text>0</xsl:text>
davecramer commented 4 months ago

17_stable coming soon ?

yosifkit commented 4 months ago

The next major release of PostgreSQL is planned to be the 17 release. This release is planned for September 2024.

https://www.postgresql.org/developer/roadmap/

davecramer commented 4 months ago

REL_17_STABLE has been created yesterday https://github.com/postgres/postgres/tree/REL_17_STABLE

yosifkit commented 4 months ago

As soon as they tag a release and publish it to their apt repos, we will add it just like 17 beta2: https://github.com/docker-library/postgres/commit/9bf5a6d620a90158d8192ee0dba05acc4464d002.

tianon commented 4 months ago

See also https://github.com/postgres/postgres/tags, "Latest Releases" on https://www.postgresql.org/, https://www.postgresql.org/ftp/source/