docker-library / pypy

Docker Official Image packaging for pypy
http://pypy.org/
MIT License
69 stars 46 forks source link

Use a newer version of setuptools for pypy3 #62

Closed olliemath closed 2 years ago

olliemath commented 2 years ago

https://github.com/docker-library/pypy/pull/61 managed to break our images in subtle ways with issues at runtime (rather than install) - I'm unsure how to upstream this as the exact issue is hard to pin down (see below image).

The fix was to revert back to the python3.7 version of setuptools. This should be the default, rather than supporting pypy 2.7 by using setuptools 44.x in the 3.7 image.

image

tianon commented 2 years ago

I was afraid of this. :disappointed:

I suppose we should mirror https://github.com/docker-library/python/pull/647 and look at https://foss.heptapod.net/pypy/pypy/-/blob/release-pypy2.7-v7.3.5/lib-python/2.7/ensurepip/__init__.py vs https://foss.heptapod.net/pypy/pypy/-/blob/release-pypy3.7-v7.3.5/lib-python/3/ensurepip/__init__.py

Concretely, that would mean:

tianon commented 2 years ago

I've got a proposal up in #63 that avoids us scraping/choosing versions at all (and instead trusting pypy to choose the appropriate versions).

olliemath commented 2 years ago

Thanks, that seems sensible