docker-library / rabbitmq

Docker Official Image packaging for RabbitMQ
http://www.rabbitmq.com/
MIT License
785 stars 417 forks source link

Add `4.1.0-beta.1` pre-release #738

Closed yosifkit closed 2 weeks ago

yosifkit commented 2 weeks ago

🎉 A new RabbitMQ release series, 4.1. Still using Ubuntu 24.04, Alpine 3.20, and OpenSSL 3.3. Bump erlang to 27 for 4.1.x (#734). Updates the download URL to drop -latest-toolchain for 4.1+ (rabbitmq-server-generic-unix-{version}.tar.xz).

Closes #737 Closes #734

michaelklishin commented 2 weeks ago

@yosifkit would it be possible to change the directory suffix to 4.1-preview or something like that? We are a few months away from an RC.

If not, that's fine with me, I understand the value of naming conventions :)

tianon commented 2 weeks ago

Yeah, we've used rc as a naming convention for "pre-releases" across DOI for a long time, but we certainly don't have to! It's easier for us if we keep the folder named that way, but it shouldn't be too hard to make sure the actual image tags don't use rc in them yet :thinking:

Right now, this will have tags 4.1.0-beta.1 and 4.1-rc (and variants like 4.1.0-beta.1-management, etc) -- would you want us to change that to 4.1-preview, or would you rather we drop that generic tag instead and only have the full explicit version? (the latter is easier, but the former isn't too bad if you prefer it)

tianon commented 2 weeks ago

Here's the easy version (drop the RC references from tags of a version that isn't an RC):

diff --git a/generate-stackbrew-library.sh b/generate-stackbrew-library.sh
index c97a15f..bf6885d 100755
--- a/generate-stackbrew-library.sh
+++ b/generate-stackbrew-library.sh
@@ -106,11 +106,15 @@ for version; do
            versionAliases+=( $fullVersion )
            fullVersion="${fullVersion%[.-]*}"
        done
+       versionAliases+=( $version )
    else
        versionAliases+=( $fullVersion )
+       if [[ "$fullVersion" == *rc* ]]; then
+           # only add "X.Y-rc" alias if it's actually an RC
+           versionAliases+=( $version )
+       fi
    fi
    versionAliases+=(
-       $version
        ${aliases[$version]:-}
    )
michaelklishin commented 2 weeks ago

@tianon no, let's keep things the way they are then. Thank you for the explanation!

tianon commented 2 weeks ago

Will do! As always, we appreciate the help/engagement :smile: