docker-library / ruby

Docker Official Image packaging for Ruby
http://www.ruby-lang.org/
BSD 2-Clause "Simplified" License
590 stars 334 forks source link

Add debian:bookworm #415

Closed sitano closed 1 year ago

sitano commented 1 year ago

bookworm distro for different Ruby versions + 2.7.8 support

tianon commented 1 year ago

See also https://github.com/docker-library/golang/pull/456#issuecomment-1498122550

ojab commented 1 year ago

Bump since it was released https://www.debian.org/News/2023/20230610

sitano commented 1 year ago

I have rebased the branch to fix conflicts. At the moment it does not compile with apline17 and 18 due to openssl version iirc, but not remember for sure. update.sh breaks versions.json for 2.7, I am not sure if I need to fix this script and what it does at all.

ojab commented 1 year ago

I believe the single change should be

diff --git a/versions.sh b/versions.sh
index 0901026..6848b79 100755
--- a/versions.sh
+++ b/versions.sh
@@ -70,8 +70,8 @@ for version in "${versions[@]}"; do
                        sha256: env.shaVal,
                        variants: [
                                (
+                                       "bookworm",
                                        "bullseye",
-                                       "buster",
                                        empty # trailing comma hack
                                | ., "slim-" + .), # https://github.com/docker-library/ruby/pull/142#issuecomment-320012893
                                (

and everything else should be autogenerated by ./update.sh (don't see any special cases for buster, so nothing else to remove + dunno why need_openssl flag is needed).

(NB: I'm not a maintainer)

ojab commented 1 year ago

Ah, missed + 2.7.8 support part. Also shouldn't be here, it's EOLed/unsupported and was dropped because of that.

yosifkit commented 1 year ago

Force pushed to drop out Ruby 2.7 and buster; also added same fix as https://github.com/docker-library/python/pull/822#discussion_r1227154811.

Edit: kept buster for Ruby 3.0 since it doesn't support OpenSSL 3.

sitano commented 1 year ago

Thank you for accepting this PR! You would be surprised how many people still sit on 2.7.x.