search

docker-mailserver / docker-mailserver-helm

Kubernetes Helm chart for docker-mailserver
https://github.com/docker-mailserver/docker-mailserver/
MIT License
107 stars 67 forks source link

helm unittest are failing #100

Open MichaelSp opened 8 months ago

MichaelSp commented 8 months ago

Is it just me, or are all unit-tests failing?

$ helm unittest charts/docker-mailserver
 FAIL   charts/docker-mailserver/tests/configmap_test.yaml
    - Execution Error:
        1 error(s) decoding:

* 'Pattern' expected type 'string', got unconvertible type 'int', value: '10993'

### Error:  1 error(s) decoding:

* 'Pattern' expected type 'string', got unconvertible type 'int', value: '10993'

but even after fixing that simple error:

Charts:      1 failed, 0 passed, 1 total
Test Suites: 5 failed, 1 passed, 6 total
Tests:       13 failed, 1 errored, 5 passed, 18 total
Snapshot:    15 passed, 15 total
Time:        71.612ms

looks pretty bad :(

Also, snapshots are not committed.

I would recommend:

cfis commented 8 months ago

Yeah I am sure that is true. I didn't update them when making a bunch of changes a month ago. I am not sure if they are worth updating or should be removed, but I agree they should not fail.