Add more dovecot ldap values

docker-mailserver / docker-mailserver-helm

Kubernetes Helm chart for docker-mailserver

https://github.com/docker-mailserver/docker-mailserver/

MIT License

107 stars 67 forks source link

Add more dovecot ldap values #31

Closed simonsystem closed 3 years ago

simonsystem commented 4 years ago

This PR adds 3 ldap-specific dovecot values, which are passed as environment variables to docker.

pod.dockermailserver.dovecot_ldap_version as DOVECOT_LDAP_VERSION
pod.dockermailserver.dovecot_default_pass_scheme as DOVECOT_DEFAULT_PASS_SCHEME
pod.dockermailserver.dovecot_auth_bind as DOVECOT_AUTH_BIND

Poorly, they are not documented in docker-mailserver's Readme. But available because of it's configomat template, which is updated on container start.

funkypenguin commented 4 years ago

Hey @simonsystem, thanks for the PR! 👍 Please would you also bump the semver on https://github.com/funkypenguin/helm-docker-mailserver/blob/master/charts/docker-mailserver/Chart.yaml, so that CI passes, and add any necessary notes / explanation to https://github.com/funkypenguin/helm-docker-mailserver/blob/master/README.md ?

Thanks! D

clayrisser commented 3 years ago

We should be able to pass custom envs so we can override things without having to wait for a pull request like this to get accepted.

https://github.com/funkypenguin/helm-docker-mailserver/pull/35