docker-mailserver / docker-mailserver-helm

Kubernetes Helm chart for docker-mailserver
https://github.com/docker-mailserver/docker-mailserver/
MIT License
107 stars 67 forks source link

update to cert-manager >= v1.0 #57

Closed MichaelSp closed 1 year ago

MichaelSp commented 2 years ago

WARNING: This is a breaking change. the dns01provider will no longer be provided as part of the Certificate but can be configured on the Issuer/ClusterIssuer level. This makes configuration of Certificates much easier.

Example Issuer configuration for cloudDNS:

apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
  name: letsencrypt-staging
spec:
  acme:
    server: https://acme-staging-v02.api.letsencrypt.org/directory
    email: <your mail>
    privateKeySecretRef:
      name: letsencrypt-staging
    solvers:
    - dns01:
        cloudDNS:
          project: my-project
          serviceAccountSecretRef:
            name: prod-clouddns-svc-acct-secret
            key: service-account.json
funkypenguin commented 2 years ago

The breaking change makes sense, it's ridiculous that our chart is so far behind in terms of cert-manager versions! However, if we're making a breaking change, convention dictates that we bump the semver major version in Charm.yaml accordingly. Would you please bump this, and resolve the current conflict?

Thanks for keeping us up-to-date! :) D

alexandre-hallaine commented 1 year ago

really need this fix