search

docker-mailserver / docker-mailserver-helm

Kubernetes Helm chart for docker-mailserver
https://github.com/docker-mailserver/docker-mailserver/
MIT License
107 stars 67 forks source link

update to v12.0.0 #75

Closed MichaelSp closed 1 year ago

funkypenguin commented 1 year ago

Aside from the (ancient) failing test, this looks fine to me.

One request, since we're introducting new functionality, semver says that the version bump should take us from 2.0.1 to 2.1.0` please.

I've reviewed https://github.com/docker-mailserver/docker-mailserver/blob/master/CHANGELOG.md, and there don't seem to be any changes which would require an update to the chart / values, so once the version is bumped (above), I'm happy to approve this one. (I'll update the testing for more modern k8s soon too!)

D

MichaelSp commented 1 year ago

You might want to compare with https://github.com/MichaelSp/docker-mailserver-helm/blob/master/.github/workflows/on-push-lint-charts.yml for reference