fix issue #11 by using lsregister

docker-practice / actions-setup-docker

Set up your GitHub Actions workflow with a specific version(18.09,19.03,20.10,nightly) of Docker ON Linux/macOS

93 stars 34 forks source link

fix issue #11 by using lsregister #12

Closed fenollp closed 2 years ago

phlummox commented 2 years ago

... @fenollp, I think this patch may cause runtime errors when used - have you tried using it on a repo yourself?

It seems to include a backtick (here, in a comment) inside a backtick-string (starting here), meaning the backstick string is interpreted as ending early.

phlummox commented 2 years ago

p.s. I have a "fix to the fix" here: https://github.com/phlummox-dev/actions-setup-docker/commit/aeefd9ac1777ed7acbc8a2b88a8dbf7bd1de0b06

fenollp commented 2 years ago

Thanks for the review and the fix! I've merged it. Here's a successful CI run of this branch as proof of it working: https://github.com/fenollp/actions-setup-docker/actions/runs/1658390147

phlummox commented 2 years ago

No worries, glad it was useful :)