Rename the script LTSP_Installer_script.sh

docker-scripts-archived / dev--LTSP

Virtual LTSP server with vagrant and/or docker-scripts.

GNU General Public License v3.0

7 stars 6 forks source link

Rename the script LTSP_Installer_script.sh #16

Closed dashohoxha closed 6 years ago

dashohoxha commented 6 years ago

Rename the script LTSP_Installer_script.sh to install.sh or config.sh, because it is obvious that it is a script and that it is about LTSP.

nehajain444 commented 6 years ago

Okay... It has too much to install and less to config. So naming it install.sh pull request - https://github.com/docker-scripts/dev--LTSP/pull/21

dashohoxha commented 6 years ago

I discarded that PR. You should make another one properly, by making a git branch first. Also it is important that you test your changes first, before committing them and making a PR. If you don't do it, who do you think is going to test them?

nehajain444 commented 6 years ago

okay. I tested it and make changes in the vagrant file. It is working now. pull request - https://github.com/docker-scripts/dev--LTSP/pull/22