made ltsp server flexible

[d78ui98]

• [x] Added settings.sh
• [x] Made changes in install.sh to load mode of operation from settings.sh
• [x] small bug fix to to allow standalone mode of operation
• [x] changes in Vagrantfile to get network address
• [x] update README.md

fixes #28

[dashohoxha]

Does it work if you set NETWORK=192.168.100.0/24 on settings.sh?

[dashohoxha]

You also need to change the configuration of VirtualBox on Vagrantfile. For the standalone case the VM should have 2 network interfaces. For the non-standalone case it should have only one. Read the task description for more details.

[dashohoxha]

You also need to change the configuration of VirtualBox on Vagrantfile.

However I am not very familiar with Ruby. Maybe @akash0x53 can give you some help with this.

[d78ui98]

Thanks @dashohoxha. Code now looks readable, beautiful and far more efficient :)

[dashohoxha]

Please also explain what steps you follow for testing this in order to make sure that everything works as expected. So that the other people can test and verify this.

[d78ui98]

Testing steps -

• Clone the repository
• Open settings.sh and set the mode of operation of ltsp-server by changing value of STANDALONE.
• By default yes is given. When means ltsp server will give IP addresses to clients.
• If you already have a DHCP server then put no or any other value inside it.
• You can also change LAN_IP variable to set the static IP address of the LTSP server
• You can change the NETWORK variable to selected which network you want your ltsp server to work in.
• Then just do a vagrant up to install ltsp to vagrant box.

I would recommend first testing the Standalone mode of operation and then the Non standalone mode of operation. Also make sure ip address is of the same network

[dashohoxha]

Testing steps -

No client is mentioned here. You cannot test a ltsp-server without running a client. Where is your client?

Actually I would recommend that you create a document that describes (to the new users) the standalone operation mode, including also some network diagrams. Then describe also the dependent (non-standalone) operation mode, again with some diagrams. And then a document that describes how to test each of these modes.

You can use the format markdown for these documents. It can be something similar to this: https://github.com/EasyGnuPG/ggpg/blob/describing-application/docs/description.md

For drawing network diagrams you can use Dia or some other tool that you are familiar with. I have used Dia many years ago and I have been happy with it. For example have a look at the network diagrams here:

• https://www.researchgate.net/publication/317181126_Building_a_Gateway_Server

[d78ui98]

Sounds good. Should I create a separate branch for this task?

[dashohoxha]

Should I create a separate branch for this task?

You can create a separate branch if you wish, or you can try using wiki: https://github.com/docker-scripts/dev--LTSP/wiki

In any case don't forget to come back and finish the existing branches: https://github.com/docker-scripts/dev--LTSP/pulls

[d78ui98]

okay. I think using wiki would be a good idea for this

[d78ui98]

I implemented same with ip address and ip link command too. But, these commands don't actually tell whether interface is connected to internet or not. So I thought best option is use route

code is tested multiple times. Please let me if we need to make other improvements or if we can merge this

[dashohoxha]

We can merge it if you want. But it is not tested unless you test it with a client: https://github.com/docker-scripts/dev--LTSP/pull/31#issuecomment-393690718

Just because the virtual box boots up and the scripts run without errors, it doesn't mean that it is configured and works correctly. When you say "made ltsp server flexible" it means that it should work both for standalone and non-standalone case. You have not tested properly none of these cases.

Anyway let us merge it now and you can continue to fix and improve it later.