add client.sh and update readme.md

docker-scripts-archived / dev--LTSP

Virtual LTSP server with vagrant and/or docker-scripts.

GNU General Public License v3.0

7 stars 6 forks source link

add client.sh and update readme.md #41

Closed d78ui98 closed 6 years ago

d78ui98 commented 6 years ago

[x] added client.sh for creating ltsp clients
[x] updated README.md for buster branch

d78ui98 commented 6 years ago

I added usage function in client.sh. Also reduced its complexity. If this is good I can create a pull request to this in bionic branch too.

dashohoxha commented 6 years ago

If this is good I can create a pull request to this in bionic branch too.

I don't know it it is good, because you have not tested it. You cannot test it because the server does not work in buster. I will accept it anyway, but you should do it correctly for bionic, testing it as well, and then come back and fix it for buster.

dashohoxha commented 6 years ago

Also try to keep pull requests and commits meaningful. For example adding the code of the client and updating README have no relation to each-other, so they should have been (ideally) separate pull requests, or at least separate commits.