search

docker-scripts-archived / dev--LTSP

Virtual LTSP server with vagrant and/or docker-scripts.
GNU General Public License v3.0
7 stars 6 forks source link

Added packer template #88

Closed d78ui98 closed 6 years ago

d78ui98 commented 6 years ago

closes #77

d78ui98 commented 6 years ago

I have tested it multiple times. Should we merge this?

dashohoxha commented 6 years ago

I have tested it as well and it seems to work.

Only that I still have that problem that I cannot use it with vagrant up (and testing.sh, etc.) I purged completely the installations of vagrant and virtual box and installed them again (standard debian installation, with apt install).

Please look into this issue and try to solve it, because users need installation instructions that work out of the box. If it does not work even for me, you cannot expect it to work for other people. For example for packer you had placed some good instructions on its README file.

dashohoxha commented 6 years ago

Should we merge this?

Feel free to merge pull requests any time you think you should. The button is always green, because I have removed the constraint for having a review. This was due to me not being able to test what you do, so it doesn't make sense to approve something that I don't know how it works, and it is not good to block it either.

d78ui98 commented 6 years ago

I have tested it as well and it seems to work.

Great!

Only that I still have that problem that I cannot use it with vagrant up

Yes. We need to first add the .box file to use it. I will update the steps in readme file.

because users need installation instructions that work out of the box.

This is a problem with vagrant itself. One cannot always get the latest version of vagrant with apt. Even if the update and upgrade packages. I tried asking vagrant community about this. But they didn't respond. I have seen everywhere people downloading vagrant with wget from https://www.vagrantup.com/downloads.html and installing with dpkg. That is one of way to ensure users always have the latest version. We should update it in the readme file

For example for packer you had placed some good instructions on its README file.

yes this time I went for very compact and to the point instructions. Will update the main readme similar way in #19 .

dashohoxha commented 6 years ago

This is a problem with vagrant itself. One cannot always get the latest version of vagrant with apt. Even if the update and upgrade packages. I tried asking vagrant community about this. But they didn't respond. I have seen everywhere people downloading vagrant with wget from https://www.vagrantup.com/downloads.html and installing with dpkg. That is one of way to ensure users always have the latest version. We should update it in the readme file

If you had used the stable version that comes with Debian (and Ubuntu) maybe there would be no such incompatibility problems. If you tell people to get it from the vagrant website, one year from now maybe there will be a new vagrant version, and the users may have again problems with the images that you are generating now.

Anyway, debian is what it is and vagrant is what it is, but you have to make sure that users always have correct instructions.

d78ui98 commented 6 years ago

Okay. I will update the instructions.