search

docker-training / ddev-labs

Labs for the workshop Docker for Enterprise Developers
15 stars 29 forks source link

self host cat pics #16

Closed bkatiemills closed 6 years ago

bkatiemills commented 6 years ago

addressing https://github.com/docker-training/presentations/issues/999

bkatiemills commented 6 years ago

@patrick-nw can you think of any reason this PR would break something? Hotfixed this without running through the whole workshop since it was pretty P0.

patrick-nw commented 6 years ago

No, I doubt it will break things, since the code was “working”, except for the munged urls to include the images.

On Fri, Apr 27, 2018 at 9:55 AM Bill Mills notifications@github.com wrote:

@patrick-nw https://github.com/patrick-nw can you think of any reason this PR would break something? Hotfixed this without running through the whole workshop since it was pretty P0.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/docker-training/ddev-labs/pull/16#issuecomment-385030537, or mute the thread https://github.com/notifications/unsubscribe-auth/APMHtxNdBZKICcg2llZazYiDnu42ObiMks5ts02agaJpZM4Tqsl8 .

-- Patrick Salsbury Senior DevOps Engineer, Nebulaworks 408-499-3907 www.nebulaworks.com