docker-training / ddev-labs

Labs for the workshop Docker for Enterprise Developers
15 stars 29 forks source link

Add "set -e" to tag-and-push.sh so we quit early if building fails #31

Closed franklouwers closed 5 years ago

franklouwers commented 5 years ago

In the tag-and-push.sh script, if the tagging fails, (because :latest wasn't build properly), but 1.0 still existed, that old version would get pushed to the Hub. One of my students ran into this, and it took us a while to figure out why what was happening.

It's best practice to "set -e" so we immediately throw an error if the tagging fails, so we don't upload any old images.