ulyssessouza commented 5 years ago

- What I did Add a docker-app image to dockerhub so that people can run it in a container or use it as a base image.
Ex: docker run -v ${PWD}:/mnt -w /mnt docker/app --help

The intent is to implement #367

- How I did it Adding a new docker image of docker-app in the Dockerfile to be exported to dockerhub. Also, a new stage in the Jenkinsfile is available so that it can push a new docker image to Dockerhub when a tag is built.

- How to verify it When pushing a new tag to git, a new docker image should be pushed to dockerhub just after passing the tests.

- Description for the changelog New images are now pushed to dockerhub as soon as a Tag is pushed to github and it passes the tests stages.

- A picture of a cute animal (not mandatory but encouraged) cao-deliver

vdemeester commented 5 years ago

Enhancement idea : build a windows image too, and use manifest tooling (manifest-tool or docker manifest) to have a multi-arch image :angel:

codecov[bot] commented 5 years ago

Codecov Report

Merging #420 into master will decrease coverage by 1.85%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
- Coverage    60.4%   58.55%   -1.86%     
==========================================
  Files          60       59       -1     
  Lines        3791     3378     -413     
==========================================
- Hits         2290     1978     -312     
+ Misses       1242     1140     -102     
- Partials      259      260       +1

Impacted Files	Coverage Δ
pkg/yatee/yatee.go	`68.5% <0%> (-11.13%)`	:arrow_down:
render/render.go	`73.25% <0%> (-8.13%)`	:arrow_down:
internal/helm/helm.go	`52.8% <0%> (-3.22%)`	:arrow_down:
types/types.go	`88.59% <0%> (-2.11%)`	:arrow_down:
types/settings/merge.go	`100% <0%> (ø)`	:arrow_up:
cmd/docker-app/renderfile.go
cmd/docker-app/render.go	`76.66% <0%> (+1.66%)`	:arrow_up:
cmd/docker-app/root.go	`77.35% <0%> (+2.78%)`	:arrow_up:
cmd/docker-app/deploy.go	`32.6% <0%> (+11.6%)`	:arrow_up:
types/settings/settings.go	`96.82% <0%> (+15.43%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b3bef0...22a4fe9. Read the comment docs.

simonferquel commented 5 years ago

With move to CNAB, we are closing this. We'll revisit the need in the future

docker / app

WIP Adds docker-app image to dockerhub #420

Codecov Report