docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub

Apache License 2.0

1.57k stars 177 forks source link

WIP (DO NOT MERGE) - Add validation just before execution of `deploy` and `push` commands. Should include `init`? #425

Closed ulyssessouza closed 5 years ago

ulyssessouza commented 5 years ago

- What I did Added validation before deploy and push

Closes: https://github.com/docker/app/issues/424

- How I did it I extracted the validation to a function, so we can call it from other commands, then it's just a question of calling it at the very beginning of the other commands and check it's return error

- How to verify it Can be tested by commenting any mandatory fields, like metadata's version then trying to push or deploy

- Description for the changelog Added validation before deploy and push mouse

codecov[bot] commented 5 years ago

Codecov Report

Merging #425 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   58.31%   58.31%           
=======================================
  Files          60       60           
  Lines        3387     3387           
=======================================
  Hits         1975     1975           
  Misses       1149     1149           
  Partials      263      263

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d3e443...19b6758. Read the comment docs.

simonferquel commented 5 years ago

Redundant with invocation-image building step