search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Image map support #434

Closed simonferquel closed 5 years ago

simonferquel commented 5 years ago

This add support for pushing / pull from and to an OCIIndex/DockerManifestList deferred to a followup PR Adds support for creating image maps, and do image remapping on install (for scenarios like applevel promotion and airgapped scenarios with DTR).

GordonTheTurtle commented 5 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "image-map-support" git@github.com:simonferquel/app.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354069184
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

simonferquel commented 5 years ago

@silvin-lubecki @rumpl I rebased this one, and stripped the cnab-to-oci integration from it (for now - I backid it up in separate branch). can you PTAL ?

simonferquel commented 5 years ago

I resolved the CI issue here, @chris-crone @silvin-lubecki PTAL ?

simonferquel commented 5 years ago

Rebased + using duffle master branch. @silvin-lubecki PTAL

codecov[bot] commented 5 years ago

Codecov Report

Merging #434 into master will increase coverage by 0.16%. The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   66.26%   66.42%   +0.16%     
==========================================
  Files          51       51              
  Lines        2715     2740      +25     
==========================================
+ Hits         1799     1820      +21     
- Misses        658      660       +2     
- Partials      258      260       +2
Impacted Files Coverage Δ
cmd/docker-app/render.go 57.5% <100%> (ø) :arrow_up:
cmd/docker-app/validate.go 88.88% <100%> (ø) :arrow_up:
render/render.go 71.6% <100%> (+1.47%) :arrow_up:
cmd/docker-app/inspect.go 88.23% <100%> (ø) :arrow_up:
cmd/docker-app/bundle.go 47.61% <100%> (ø) :arrow_up:
internal/inspect/inspect.go 87.01% <100%> (ø) :arrow_up:
internal/packager/cnab.go 95.5% <78.94%> (-4.5%) :arrow_down:
internal/compose/compose.go 70.73% <83.33%> (+2.31%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dcbc2dd...f6142ba. Read the comment docs.