search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Rename Settings to Parameters #438

Closed silvin-lubecki closed 5 years ago

silvin-lubecki commented 5 years ago

- What I did

⚠️ Breaking Change To better fit with CNAB vocabulary, I renamed the settings.yml file and all the settings reference to parameters.yml / parameters.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

image

codecov[bot] commented 5 years ago

Codecov Report

Merging #438 into master will increase coverage by 0.04%. The diff coverage is 85%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #438      +/-   ##
=========================================
+ Coverage   61.86%   61.9%   +0.04%     
=========================================
  Files          49      49              
  Lines        2386    2389       +3     
=========================================
+ Hits         1476    1479       +3     
  Misses        707     707              
  Partials      203     203
Impacted Files Coverage Δ
types/parameters/opts.go 100% <ø> (ø)
internal/names.go 100% <ø> (ø) :arrow_up:
cmd/docker-app/image-add.go 0% <0%> (ø) :arrow_up:
cmd/docker-app/validate.go 88.88% <100%> (ø) :arrow_up:
internal/renderer/renderer.go 100% <100%> (ø) :arrow_up:
loader/loader.go 79.24% <100%> (+1.24%) :arrow_up:
types/parameters/merge.go 100% <100%> (ø)
types/parameters/load.go 84.61% <100%> (ø)
cmd/docker-app/inspect.go 88.23% <100%> (ø) :arrow_up:
types/parameters/parameters.go 92.06% <100%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bf8ecad...c0c9cd6. Read the comment docs.