Closed rumpl closed 5 years ago
Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:
$ git clone -b "refactor-parameters" git@github.com:rumpl/app.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f
Amending updates the existing PR. You DO NOT need to open a new one.
Although, please sign your commits
Merging #457 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #457 +/- ##
=======================================
Coverage 67.44% 67.44%
=======================================
Files 52 52
Lines 2841 2841
=======================================
Hits 1916 1916
Misses 664 664
Partials 261 261
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0c1ee92...4746515. Read the comment docs.
@ulyssessouza PTAL 😸
LGTM
Making the parameter resolution reusable by install/upgrade and inspect in the future.
- What I did Refactored the code that manages bundle parameters and overrides.
- How I did it With Silvin, with tests.
- A picture of a cute animal (not mandatory but encouraged) Happiest animal on earth, a chipper quokka, don't say it isn't cute.