Closed simonferquel closed 5 years ago
We have now Push
and Resolve registry references
implemented.
From there we will split Work with @ijc:
Will merge back to this branch once we're done
Merging #466 into master will increase coverage by
6.87%
. The diff coverage is67.37%
.
@@ Coverage Diff @@
## master #466 +/- ##
==========================================
+ Coverage 64.36% 71.24% +6.87%
==========================================
Files 53 50 -3
Lines 3062 2438 -624
==========================================
- Hits 1971 1737 -234
+ Misses 848 474 -374
+ Partials 243 227 -16
Impacted Files | Coverage Δ | |
---|---|---|
cmd/docker-app/main.go | 44.44% <0%> (-5.56%) |
:arrow_down: |
internal/packager/extract.go | 62.5% <0%> (-2.81%) |
:arrow_down: |
cmd/docker-app/root.go | 100% <100%> (+7.14%) |
:arrow_up: |
cmd/docker-app/bundle.go | 66.07% <100%> (-2.68%) |
:arrow_down: |
cmd/docker-app/install.go | 65.07% <100%> (-6.01%) |
:arrow_down: |
cmd/docker-app/cnab.go | 64.04% <27.27%> (-16.7%) |
:arrow_down: |
cmd/docker-app/push.go | 65.43% <61.64%> (-4.97%) |
:arrow_down: |
cmd/docker-app/upgrade.go | 65.3% <66.66%> (-4.54%) |
:arrow_down: |
internal/store/store.go | 71.42% <71.42%> (ø) |
:arrow_up: |
cmd/docker-app/pull.go | 80% <73.33%> (+16%) |
:arrow_up: |
... and 10 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 00f88e0...29d48dc. Read the comment docs.
I can't understand why I have a vendoring issue here... tried with wsl to do make vendor, and git diff reports nothing changed :(
Closing in favor of #470 (keeping the branch alive for commit + comments history)
This leverages cnab-to-oci to push and pull built bundles. This also introduce a local bundle store to avoid network round-trips when doing multiple actions on the same bundle referenced using a registry ref.