search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Transform docker-app as a docker-cli plugin #469

Closed silvin-lubecki closed 5 years ago

silvin-lubecki commented 5 years ago

- What I did Transform docker-app as a docker-cli plugin using docker-cli helpers.

Add a new binary docker-app-standalone which is in fact the old docker-app before its pluginization.

Now each released tar.gz file per os comes with two binaries in it:

- How to verify it

With a master docker-cli built on your own:

$ make bin/docker-app
$ mkdir ~/.docker/cli-plugins && cp bin/docker-app ~/.docker/cli-plugins
$ docker
...
Management Commands:
  app*        Docker Application Packages (Docker Inc., v0.6.0...)
...

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged) image

ijc commented 5 years ago

At least the pr-merge CI job is suffering from https://github.com/docker/cli/pull/1654#issuecomment-468659940 (that CI has a daemon <18.09). Awaiting maintainer feedback before deciding how to address.

ijc commented 5 years ago

pr-head seems to be a different problem (at least so far), vendoring is unclean apparently:


These files were changed:

 M vendor/github.com/docker/cli/cli/command/cli.go
codecov[bot] commented 5 years ago

Codecov Report

Merging #469 into master will increase coverage by 0.02%. The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
+ Coverage   69.38%   69.41%   +0.02%     
==========================================
  Files          50       50              
  Lines        2515     2501      -14     
==========================================
- Hits         1745     1736       -9     
+ Misses        540      537       -3     
+ Partials      230      228       -2
Impacted Files Coverage Δ
internal/commands/bundle.go 66.07% <ø> (ø)
internal/commands/validate.go 88.88% <ø> (ø)
internal/commands/split.go 80% <ø> (ø)
internal/commands/pull.go 80% <ø> (ø)
internal/commands/init.go 100% <ø> (ø)
internal/commands/render.go 57.5% <ø> (ø)
internal/commands/merge.go 61.01% <ø> (ø)
internal/commands/completion.go 48.48% <ø> (ø)
internal/commands/push.go 38.6% <ø> (ø)
internal/commands/parameters.go 90.69% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 36fd67f...30fda72. Read the comment docs.