Closed seemethere closed 5 years ago
Merging #475 into master will decrease coverage by
0.03%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #475 +/- ##
==========================================
- Coverage 69.45% 69.41% -0.04%
==========================================
Files 50 50
Lines 2501 2501
==========================================
- Hits 1737 1736 -1
- Misses 536 537 +1
Partials 228 228
Impacted Files | Coverage Δ | |
---|---|---|
types/parameters/parameters.go | 92.06% <0%> (-1.59%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8b1b2d0...151e1c5. Read the comment docs.
@codecov I didn't even touch those files 🙄
- What I did Adds a dynamic make target to allow for making a dynamic binary without having to do ugly
GO_BUILD
mangling.Default functionality should remain the same.
- How I did it
expand
```diff diff --git a/Makefile b/Makefile index 2a6e18eb..e3a9fa41 100644 --- a/Makefile +++ b/Makefile @@ -24,8 +24,9 @@ ifeq ($(OS),Windows_NT) EXEC_EXT := .exe endif -GO_BUILD := CGO_ENABLED=0 go build -tags=$(BUILDTAGS) -ldflags=$(LDFLAGS) -GO_TEST := CGO_ENABLED=0 go test -tags=$(BUILDTAGS) -ldflags=$(LDFLAGS) +STATIC_FLAGS= CGO_ENABLED=0 +GO_BUILD = $(STATIC_FLAGS) go build -tags=$(BUILDTAGS) -ldflags=$(LDFLAGS) +GO_TEST = $(STATIC_FLAGS) go test -tags=$(BUILDTAGS) -ldflags=$(LDFLAGS) all: bin/$(BIN_NAME) test @@ -41,6 +42,10 @@ cross-standalone: bin/${BIN_STANDALONE_NAME}-linux bin/${BIN_STANDALONE_NAME}-da e2e-cross: bin/$(BIN_NAME)-e2e-linux bin/$(BIN_NAME)-e2e-darwin bin/$(BIN_NAME)-e2e-windows.exe +.PHONY: dynamic +dynamic: STATIC_FLAGS := +dynamic: bin/$(BIN_NAME) + .PHONY: bin/${BIN_STANDALONE_NAME}-windows bin/${BIN_STANDALONE_NAME}-%.exe bin/${BIN_STANDALONE_NAME}-%: cmd/${BIN_STANDALONE_NAME} check_go_env GOOS=$* $(GO_BUILD) -o $@ ./$< ```- How to verify it Run,
make dynamic
- Description for the changelog
No changelog entry needed
- A picture of a cute animal (not mandatory but encouraged)