search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Push prints error messages correctly #476

Closed simonferquel closed 5 years ago

simonferquel commented 5 years ago

- What I did

When using docker-app as a plugin, error messages did not appear in the console. This is due to the fact that we did never un-mute the docker CLI structure when Pushing, and that the RunPlugin uses dockerCli.Err() to report error messages to the user.

This fixes the issue by using the defer muteDockerCli(cli)() pattern that is used everywhere else.

- How I did it

Make sure the docker CLI is unmuted when leaving runPush using the defer muteDockerCli(cli)() pattern.

- How to verify it

Try to push a bundle in a repo you don't have push right in.

codecov[bot] commented 5 years ago

Codecov Report

Merging #476 into master will decrease coverage by 0.19%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #476     +/-   ##
=========================================
- Coverage   69.45%   69.25%   -0.2%     
=========================================
  Files          50       50             
  Lines        2501     2501             
=========================================
- Hits         1737     1732      -5     
- Misses        536      540      +4     
- Partials      228      229      +1
Impacted Files Coverage Δ
internal/commands/push.go 38.6% <100%> (ø) :arrow_up:
types/parameters/parameters.go 85.71% <0%> (-7.94%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8b1b2d0...b53ec2a. Read the comment docs.