docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Add push/pull info in readme #477

Closed simonferquel closed 5 years ago

simonferquel commented 5 years ago

- What I did

Added a bit more details in the readme about push/pull operations

- How I did it

Modified the README.md file

- How to verify it

Read it ! :)

ijc commented 5 years ago

Is CI stuck on this one?

simonferquel commented 5 years ago

Further down the current doc says:

Note: To use Application Packages as images (i.e.: save, push, or install when package is not present locally) on Windows, one must be in Linux container mode.

Is that still true for all those verbs?

Hmm, it is different now:

codecov[bot] commented 5 years ago

Codecov Report

Merging #477 into master will increase coverage by 0.11%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #477      +/-   ##
==========================================
+ Coverage   69.41%   69.53%   +0.11%     
==========================================
  Files          50       51       +1     
  Lines        2501     2629     +128     
==========================================
+ Hits         1736     1828      +92     
- Misses        537      569      +32     
- Partials      228      232       +4
Impacted Files Coverage Δ
internal/commands/dockerdesktop.go 46.75% <0%> (ø)
internal/store/store.go 72% <0%> (+0.57%) :arrow_up:
types/parameters/parameters.go 96.82% <0%> (+4.76%) :arrow_up:
internal/commands/cnab.go 79.2% <0%> (+15.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 803e955...2390a15. Read the comment docs.

silvin-lubecki commented 5 years ago

@simonferquel : @dschulten has a good point here https://github.com/docker/app/issues/481#issuecomment-472999795 we should add your explanation somewhere in the README.

chris-crone commented 5 years ago

I've included this in #512.