search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Expanded docker-compose parameters on init #486

Closed zappy-shu closed 5 years ago

zappy-shu commented 5 years ago

- What I did

Fixed issue #484 by expanding docker-compose parameters on init

- How I did it

Expand parameters with pre-existing parameters.FromFlatten() before marshaling to yaml when initializing from compose file in initFromComposeFile().

- How to verify it

Unit test has been added to check expansion of parameters using the example compose file in issue #484 altered to use variables in port fields as variable substitution is not supported for the image field.

codecov[bot] commented 5 years ago

Codecov Report

Merging #486 into master will increase coverage by 0.07%. The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
+ Coverage    69.4%   69.48%   +0.07%     
==========================================
  Files          50       50              
  Lines        2553     2556       +3     
==========================================
+ Hits         1772     1776       +4     
  Misses        545      545              
+ Partials      236      235       -1
Impacted Files Coverage Δ
internal/packager/init.go 56.52% <77.77%> (+1.7%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d766735...195a374. Read the comment docs.