search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Bump cnab-to-oci and containerd #487

Closed simonferquel closed 5 years ago

simonferquel commented 5 years ago

- What I did

Bumped cnab-to-oci and containerd for better Push support

chris-crone commented 5 years ago

Looks like linting is failing on vendored code:

Linting...
vendor/github.com/containerd/containerd/signals_unix.go:42:17:warning: SignalNum not declared by package unix (gosimple)
vendor/github.com/containerd/containerd/signals_unix.go:42:17:warning: SignalNum not declared by package unix (interfacer)
vendor/github.com/containerd/containerd/signals_unix.go:42:17:warning: SignalNum not declared by package unix (unconvert)
vendor/github.com/containerd/containerd/signals_unix.go:42:17:warning: parameter SignalNum not declared by package unix (unparam)
vendor/github.com/containerd/containerd/signals_unix.go:42:17:warning: SignalNum not declared by package unix (unused)
vendor/github.com/containerd/containerd/signals_unix.go:42:12:error: undefined: unix.SignalNum (vet)
make: *** [Makefile:74: lint] Error 1
docker.Makefile:107: recipe for target 'lint' failed
make: *** [lint] Error 2
script returned exit code 2
ijc commented 5 years ago

We should stop linting vendored code...

silvin-lubecki commented 5 years ago

That's weird, I really thought we already did...

ijc commented 5 years ago

We just do gometalinter --config=gometalinter.json ./..., TBH I thought that excluded vendor/ by itself, but I'm never 100% sure which tools do or don't.

ijc commented 5 years ago

The current failure though was the network race/flake. I hit redo...

simonferquel commented 5 years ago

The problem was that it actually wont build because bumping containerd required us to bump golang/x/sys (added that and amended the original commit)

codecov[bot] commented 5 years ago

Codecov Report

Merging #487 into master will increase coverage by 0.11%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
+ Coverage    69.4%   69.52%   +0.11%     
==========================================
  Files          50       50              
  Lines        2553     2553              
==========================================
+ Hits         1772     1775       +3     
+ Misses        545      543       -2     
+ Partials      236      235       -1
Impacted Files Coverage Δ
types/parameters/parameters.go 96.82% <0%> (+4.76%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d766735...534ad7f. Read the comment docs.

simonferquel commented 5 years ago

@chris-crone @ijc PTAL (CI is green)