Closed silvin-lubecki closed 5 years ago
Happy to let you handle the rebase/conflicts :trollface:
Merging #492 into master will increase coverage by
0.37%
. The diff coverage is80.7%
.
@@ Coverage Diff @@
## master #492 +/- ##
==========================================
+ Coverage 68.77% 69.15% +0.37%
==========================================
Files 51 51
Lines 2645 2684 +39
==========================================
+ Hits 1819 1856 +37
- Misses 585 588 +3
+ Partials 241 240 -1
Impacted Files | Coverage Δ | |
---|---|---|
internal/names.go | 100% <ø> (ø) |
:arrow_up: |
internal/packager/cnab.go | 96.66% <100%> (+1.31%) |
:arrow_up: |
internal/commands/root.go | 100% <100%> (ø) |
:arrow_up: |
internal/commands/status.go | 66.66% <50%> (-4.77%) |
:arrow_down: |
internal/commands/uninstall.go | 65.78% <50%> (ø) |
:arrow_up: |
internal/commands/inspect.go | 80.95% <60%> (+2.57%) |
:arrow_up: |
internal/commands/install.go | 63.63% <66.66%> (ø) |
:arrow_up: |
internal/commands/upgrade.go | 63.46% <66.66%> (ø) |
:arrow_up: |
internal/commands/cnab.go | 68.15% <68.96%> (-1.32%) |
:arrow_down: |
internal/commands/render.go | 81.25% <73.91%> (+23.75%) |
:arrow_up: |
... and 5 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 7d5ceb6...4822d4f. Read the comment docs.
PTAL @ijc as I cleaned lots of things since your last review:
omitempty
missing) and in the e2e tests@ijc PTAL
Got rid of the ride
😄
- What I did I refactored and cleaned some things in the produced
bundle.json
, including:Apply-To
action indications for custom parametersstateless
new indication for custom actionsThen I introduced a new
render
custom action, adding also a new custom parameter to selectyaml|json
output format, and moved the render code into thecnab-run
binary.- How to verify it
render
should still work!- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)