docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub

Apache License 2.0

1.57k stars 177 forks source link

some CI improvements #498

Closed ijc closed 5 years ago

ijc commented 5 years ago

I'd like to do a few things:

[x] use gotestsum for unit tests (and enable export of junit file to Jenkins)
[x] use gotestsum for e2e tests (and enable export of junit file to Jenkins)
[x] switch to golangci-lint (replacing deprecated gometalinter)

codecov[bot] commented 5 years ago

Codecov Report

Merging #498 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #498   +/-   ##
=======================================
  Coverage   71.11%   71.11%           
=======================================
  Files          51       51           
  Lines        2849     2849           
=======================================
  Hits         2026     2026           
  Misses        594      594           
  Partials      229      229

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update baf0b24...7219043. Read the comment docs.

ijc commented 5 years ago

I've dropped the WIP.

In addition to the original set of goals I also ended up sprinkling some ansiColor('xterm') around various commands in an attempt to make the logs a bit more readable.

The go get foo@version I used here is go 1.12 only, so we may want to hold off on merging until 1.12.2 is released (with fixes for https://github.com/golang/go/issues/30977 and https://github.com/golang/go/issues/31125), I'm not sure if we are still considering rolling back to 1.11 in the meantime but merging this would complicate that.

ijc commented 5 years ago

I added a DNM tag pending the 1.12.2 release..

ijc commented 5 years ago

Thinking about this some more I think we can merge this without waiting for go 1.12.2, it hasn't affected this repo so far and anyone who wants to build with another compiler has access to the native build paths. I've therefore removed the DNM tag.

thaJeztah commented 5 years ago