Push without tagging invocation image - Githubissues

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub

Apache License 2.0

1.57k stars 177 forks source link

Push without tagging invocation image #506

Closed simonferquel closed 5 years ago

simonferquel commented 5 years ago

- What I did

Changed the push logic to avoid tagging the invocation image

- How I did it

Docker push cannot push an image without tagging it. This changes the push logic by:

using docker save to export the invocation image
using containerd to manipulate it (compress layers, reconstruct image manifest)
using containerd to push the resulting manifest

- How to verify it

e2e-tests cover that. unit tests for this seems overly complicated to do. Maybe @silvin-lubecki has an idea how to do that