docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub

Apache License 2.0

1.57k stars 177 forks source link

Show application reference in the list command #517

Closed silvin-lubecki closed 5 years ago

silvin-lubecki commented 5 years ago

- What I did Added a REFERENCE column, showing the registry reference, or "local" if the application was installed from a local CNAB bundle.

⚠️ On top of #510

- How to verify it

$ docker app install slubecki/example:v1.0.0 --name toto
Creating network toto_default
Creating service toto_hello
Application "toto" installed on context "default"

$ docker app ls
INSTALLATION APPLICATION          LAST ACTION RESULT  CREATED    MODIFIED  REFERENCE
simple       simple (1.1.0-beta1) install     failure 16 hours   16 hours
toto         hello-world (0.1.0)  install     success 11 seconds 8 seconds docker.io/slubecki/example:v1.0.0

- Description for the changelog

Show application reference in the list command

- A picture of a cute animal (not mandatory but encouraged)

codecov[bot] commented 5 years ago

Codecov Report

Merging #517 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #517   +/-   ##
=======================================
  Coverage   70.09%   70.09%           
=======================================
  Files          55       55           
  Lines        2996     2996           
=======================================
  Hits         2100     2100           
  Misses        620      620           
  Partials      276      276

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update be837ae...8f246ae. Read the comment docs.

chris-crone commented 5 years ago

+1 for empty string instead of local

silvin-lubecki commented 5 years ago

"local" removed and forced push