search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

fix: Add empty build args map on build #565

Closed rumpl closed 5 years ago

rumpl commented 5 years ago

- What I did

Docker client sends the BuildArgs even if it's nil, adding an empty map makes sure we don't send nil container objects.

- How I did it

Added an empty BuildArgs when calling ImageBuild

- How to verify it

docker app install should work

- A picture of a cute animal (not mandatory but encouraged) image

codecov[bot] commented 5 years ago

Codecov Report

Merging #565 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
+ Coverage   70.26%   70.27%   +<.01%     
==========================================
  Files          55       55              
  Lines        3161     3162       +1     
==========================================
+ Hits         2221     2222       +1     
  Misses        643      643              
  Partials      297      297
Impacted Files Coverage Δ
internal/commands/bundle.go 62.5% <100%> (+0.43%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cfc0281...239edc4. Read the comment docs.