Closed jcsirot closed 5 years ago
thaJeztah
commented
5 years ago Wondering if the default should be reversed, and we should push all platforms unless specific --platform(s) are specified.
(If we do choose to have the "all-platforms" flag, it should produce a "conflicting options" error if --platform is also set)
silvin-lubecki
commented
5 years ago Wondering if the default should be reversed, and we should push all platforms unless specific --platform(s) are specified.
@thaJeztah that is the current behavior, but the main issue is pushing by default all the platforms for all the multi platform services is quite heavy, even if you only use the linux/amd64 platform.
jcsirot
commented
5 years ago @thaJeztah @chris-crone a check verifying that both flags --all-platforms and --platform are mutually exclusive has been added
silvin-lubecki
commented
5 years ago Could you also squash your commits? 🦁
codecov[bot]
commented
5 years ago Merging #567 into master will not change coverage. The diff coverage is
n/a.
@@ Coverage Diff @@
## master #567 +/- ##
=======================================
Coverage 70.23% 70.23%
=======================================
Files 55 55
Lines 3286 3286
=======================================
Hits 2308 2308
Misses 671 671
Partials 307 307Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 04c3a28...990c55f. Read the comment docs.
- What I did A new flag
--all-platformshas been added. By default only thelinux/amd64architecture will be pushed to the registry.- How to verify it A unit test has been added to ensure the flags are correctly handled. TODO: a more complete e2e test
- Description for the changelog The default pushed architecture is now linux/amd64. Using the flag --all-platforms will make the push command to push to the registry all available architecture of the service images.
- A picture of a cute animal (not mandatory but encouraged)