search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Revert document detection on single file format #573

Closed silvin-lubecki closed 5 years ago

silvin-lubecki commented 5 years ago

- What I did

With the current implementation we lose most of the validation errors while detecting which part is what.

This is clearly not the right solution, so I prefer to revert and go back to the old behavior: fixed order.

- A picture of a cute animal (not mandatory but encouraged)

image

codecov[bot] commented 5 years ago

Codecov Report

Merging #573 into master will decrease coverage by 0.09%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #573     +/-   ##
=========================================
- Coverage   70.67%   70.58%   -0.1%     
=========================================
  Files          55       55             
  Lines        3223     3209     -14     
=========================================
- Hits         2278     2265     -13     
  Misses        646      646             
+ Partials      299      298      -1
Impacted Files Coverage Δ
loader/loader.go 85.71% <100%> (+2.59%) :arrow_up:
types/parameters/parameters.go 92.06% <0%> (-4.77%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4de4c3f...b81c279. Read the comment docs.