Closed jcsirot closed 5 years ago
Merging #585 into master will increase coverage by
0.35%
. The diff coverage is92.45%
.
@@ Coverage Diff @@
## master #585 +/- ##
==========================================
+ Coverage 70.74% 71.09% +0.35%
==========================================
Files 55 55
Lines 3247 3242 -5
==========================================
+ Hits 2297 2305 +8
+ Misses 649 642 -7
+ Partials 301 295 -6
Impacted Files | Coverage Δ | |
---|---|---|
internal/commands/status.go | 83.33% <100%> (+1.7%) |
:arrow_up: |
internal/commands/uninstall.go | 51.02% <100%> (+2%) |
:arrow_up: |
internal/commands/upgrade.go | 60.34% <100%> (+2.01%) |
:arrow_up: |
internal/commands/install.go | 65.71% <100%> (+1.82%) |
:arrow_up: |
internal/commands/parameters.go | 88.5% <89.47%> (+0.41%) |
:arrow_up: |
internal/commands/cnab.go | 74.09% <93.33%> (+0.9%) |
:arrow_up: |
types/parameters/parameters.go | 96.82% <0%> (+4.76%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8d52f6d...b9aa0ed. Read the comment docs.
Merging #585 into master will increase coverage by
0.26%
. The diff coverage is92.45%
.
@@ Coverage Diff @@
## master #585 +/- ##
========================================
+ Coverage 70.74% 71% +0.26%
========================================
Files 55 55
Lines 3247 3242 -5
========================================
+ Hits 2297 2302 +5
+ Misses 649 644 -5
+ Partials 301 296 -5
Impacted Files | Coverage Δ | |
---|---|---|
internal/commands/uninstall.go | 51.02% <100%> (+2%) |
:arrow_up: |
internal/commands/status.go | 83.33% <100%> (+1.7%) |
:arrow_up: |
internal/commands/upgrade.go | 60.34% <100%> (+2.01%) |
:arrow_up: |
internal/commands/install.go | 65.71% <100%> (+1.82%) |
:arrow_up: |
internal/commands/parameters.go | 88.5% <89.47%> (+0.41%) |
:arrow_up: |
internal/commands/cnab.go | 74.09% <93.33%> (+0.9%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8d52f6d...8b9556c. Read the comment docs.
- What I did The dependency on Duffle was not required anymore since Docker driver implementation moved to cnab-go library. This PR also includes a minor refactoring in parameters.go in order to handle a small API change in cnab-go
- A picture of a cute animal (not mandatory but encouraged)