search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Issue running make, getting `gotestsum: not found` #586

Closed sspaink closed 5 years ago

sspaink commented 5 years ago

When running the command make it fails to run the unit tests and returns the error gotestsum: not found. The quick fix is to simply run go get gotest.tools/gotestsum, and this could be the right answer but this isn't mentioned in the BUILDING.md and it is automated in the docker.Makefile.

So my question is, should the BUILDING.md be updated to mention this step ? Or should the Makefile be updated to run git clone -q https://github.com/gotestyourself/gotestsum like the docker.Makefile does?

Thanks!

Steps to reproduce the issue:

  1. Run make
  2. Get to: Running unit tests...

Describe the results you received: gotestsum: not found

Describe the results you expected: The unit tests to execute

Additional information you deem important (e.g. issue happens only occasionally):

Output of docker version:

Version: 18.09.7

Output of docker-app version:

Latest checkout from master
jcsirot commented 5 years ago

Hi @BattleBas Thank you for opening this ticket. Indeed we are going to update BUILDING.md