search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

[WIP] Hardening the interpolation of parameters containing special characters #587

Open jcsirot opened 5 years ago

jcsirot commented 5 years ago

- What I did Fixes https://github.com/docker/app/issues/574

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

TBD

codecov[bot] commented 5 years ago

Codecov Report

Merging #587 into master will increase coverage by 1.8%. The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #587     +/-   ##
=========================================
+ Coverage   70.74%   72.55%   +1.8%     
=========================================
  Files          55       54      -1     
  Lines        3247     2827    -420     
=========================================
- Hits         2297     2051    -246     
+ Misses        649      511    -138     
+ Partials      301      265     -36
Impacted Files Coverage Δ
internal/version.go 92.85% <ø> (-0.48%) :arrow_down:
internal/commands/inspect.go 81.81% <0%> (ø) :arrow_up:
internal/commands/render.go 81.25% <0%> (ø) :arrow_up:
internal/packager/extract.go 62.5% <0%> (ø) :arrow_up:
render/render.go 76.38% <100%> (+4.78%) :arrow_up:
internal/store/bundle.go 68.88% <100%> (ø) :arrow_up:
internal/commands/status.go 83.33% <100%> (+1.7%) :arrow_up:
internal/log/log.go 100% <100%> (ø)
internal/commands/uninstall.go 51.02% <100%> (+2%) :arrow_up:
internal/packager/packing.go 57.44% <100%> (+29.48%) :arrow_up:
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8d52f6d...72b27fc. Read the comment docs.