docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

[TAR-995 ]ADDED License scan stage to occur pre-commit in Jenkins #598

Closed zelahi closed 5 years ago

zelahi commented 5 years ago

Signed-off-by: Zuhayr Elahi elahi.zuhayr@gmail.com

- What I did I added a stage which executes License scans against docker/app

- How I did it There were two Makefile commands that were added: fossa-analyze and fossa-test. The analyze executes a command which uploads a fossa report here: https://app.fossa.com/projects/custom%2B11%2Fgit%40github.com%3Adocker%2Fapp/refs/branch/master/ceac1cf22d174a9ed8118f03b122024c7459d3b4

After executing a scan, it then performs the fossa test command which looks at the scan for license violations

- How to verify it

I executed the fossa-analyze command locally: BRANCH_NAME=master make fossa-analyze

Then executed fossa-test which: make fossa-test

The other way I verified that this worked was through running the CI

- Description for the changelog Execute scan for license issues on project commit

- A picture of a cute animal (not mandatory but encouraged) image

GordonTheTurtle commented 5 years ago

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "integrate-fossa-scans-pre-commit" git@github.com:zelahi/app.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842359013856
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

codecov[bot] commented 5 years ago

Codecov Report

Merging #598 into master will increase coverage by 0.53%. The diff coverage is 77.94%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #598      +/-   ##
=========================================
+ Coverage   72.36%   72.9%   +0.53%     
=========================================
  Files          54      53       -1     
  Lines        2761    2827      +66     
=========================================
+ Hits         1998    2061      +63     
+ Misses        506     505       -1     
- Partials      257     261       +4
Impacted Files Coverage Δ
internal/commands/status.go 83.33% <100%> (ø) :arrow_up:
internal/commands/list.go 84.12% <100%> (+1.07%) :arrow_up:
internal/commands/bundle.go 62.36% <100%> (ø) :arrow_up:
internal/packager/init.go 67.3% <100%> (+10.78%) :arrow_up:
internal/commands/root.go 73.11% <7.14%> (-11.89%) :arrow_down:
render/render.go 80.23% <93.1%> (+3.84%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8dcf633...95438af. Read the comment docs.

zelahi commented 5 years ago

@ndeloof just made the changes requested. Thanks for the feedback! Let me know if there is anything else I would need to do =)