search

docker / app

Make your Docker Compose applications reusable, and share them on Docker Hub
Apache License 2.0
1.57k stars 177 forks source link

Don't print logs when "-o -" flag is set #599

Closed rumpl closed 5 years ago

rumpl commented 5 years ago

- What I did

Made it so that only the bundle is printed when "-o -" flag is given.

- How to verify it

Run docker app bundle examples/hello-world/example-hello-world.dockerapp -o - | grep Invocation, this should print out 0 lines

- A picture of a cute animal (not mandatory but encouraged) image

jcsirot commented 5 years ago

Maybe we could rename this PR since the log are not written to stderr

rumpl commented 5 years ago

Updated the PR title

codecov[bot] commented 5 years ago

Codecov Report

Merging #599 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #599   +/-   ##
=======================================
  Coverage   72.36%   72.36%           
=======================================
  Files          54       54           
  Lines        2761     2761           
=======================================
  Hits         1998     1998           
  Misses        506      506           
  Partials      257      257
Impacted Files Coverage Δ
internal/commands/bundle.go 62.36% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8dcf633...5c2143d. Read the comment docs.